Sorry, I must have misunderstood your request for changes. I thought you were under the impression that we had not implemented something yet and / or that it was possible to protect cPanel itself. It was not a blowback, I was just explaining what is and what is not possible. I am also very direct in my communication which might be misconstrued as aggressive. I don't do aggressive. I do direct.
My question was whether AdminToolsPro had a means to suppress the injections themselves, but I take your answer to that as 'no,' but you never advertised it as such and I am not disappointed at all with the software. Rather, the opposite. AdminTools Pro is doing more than I could have possibly expected.
This is a misleading question to ask yourself because it lacks context. You still don't know where the attack came from. You have made an assumption but you don't have hard evidence. So let's start with where.
If the compromise came from a vulnerability in Joomla or one of its extensions running inside Joomla it is possible to configure Admin Tools in such a way as to prevent it. If your site was compromised because your hosting account or, worse, your server or your entire host network was compromised you can't prevent it. If the attack doesn't come through the Joomla application, inside of which Admin Tools runs, it cannot be stopped by Admin Tools or any other security exception. Likewise, if a file is uploaded by an extension which circumvents the Joomla file upload protections (either by disabling them or by having a directly web accessible .php file) the upload cannot be stopped by Admin Tools.
But that's a third of the story. There are another two layers of protection.
The .htaccess Maker will prevent direct web access to pretty much everything except static (non-executable) media, Joomla's index.php files and whatever you explicitly allow. Depending on what the attacker did it's conceivable that they did upload malicious files but can go nowhere with them because they cannot execute them.
The third layer is the PHP File Change Scanner. This is meant to help you figure out if you did get hacked by something which didn't go through the Joomla application. As the article you linked points out, the malicious files are inert. They need a change in a system .php file (usually index.php) to include the malicious code. However, such a change will be caught by the PHP File Change Scanner. That's what I was trying to tell you before when I was explaining why you don't need to add ICO files to the scanned extensions list.
That's why I am saying that your question is misleading. Even if you see the files on your site, Admin Tools may be already protecting you from the attack.
I'm not sure they successfully hacked our 32-character random username and our 32-character random cPanel password - my guess is the break happens at the hosting level (a bigger problem, and it seems specific to cPanel). And I agree, it's not novel - it's widespread and well-documented.
Objection on two counts :)
Brute forcing a password is rarely an issue unless you use a compromised or short password with a relatively short username. This doesn't mean your credentials can't leak. For example FileZilla on Windows was notorious for a while for including what is basically spyware. Even before that and long after that, it would store credentials unencrypted in a deterministic location. Needless to say, malware was hoovering it up and use it to automatically hack sites. All it takes is one person dropping the ball on operational security for credentials to be compromised. Again, though, you are not sure that this is how the attacker got access.
I also object the assertion that it's a cPanel issue per se. All my sites and our business site are on cPanel. No such incidents, like with millions of sites hosted using cPanel. Now, if your host is using an outdated version of cPanel with known vulnerabilities that's another issue. But making the assertion that cPanel itself is definitively vulnerable is a stretch and unwarranted.
I do understand your frustration dealing with an attack that seems to span multiple hosting accounts. I'd recommend finding out where the attack came from before leaping to conclusions. Confirmation bias is a thing.
Nicholas K. Dionysopoulos
Lead Developer and Director
🇬🇷Greek: native 🇬🇧English: excellent 🇫🇷French: basic • 🕐 My time zone is Europe / Athens
Please keep in mind my timezone and cultural differences when reading my replies. Thank you!