Support

That's strange. I could imagine why this could happen (I used a Windows computer to build the package) but I did check and the files used to generate the NginX configuration file don't have CRLF endings. Is it possible that you used FTP to upload the files or have enabled Joomla's FTP mode prior to installing or updating Admin Tools? That could cause some servers to transfer the files in ASCII mode which does indeed change the line endings on transport.

What I meant is that if you installed Admin Tools using FTP then the administrator/components/com_admintools/Model/NginXConfMaker.php file will have CRLF line endings instead of LF. Why does that matter? Let's see some points.

In that file there are the literal string blocks which get concatenated into the nginx.conf file. Therefore, if that file has CRLF line endings you get CRLF line endings in your nginx.conf (and that's the only way it can happen). So, the problem we have to deal with is that administrator/components/com_admintools/Model/NginXConfMaker.php has CRLF endings.

I know I built the installation package on my Windows computer. I checked my computer and I see that the file has LF endings. So it couldn't have been a problem in the package.

Which leaves us wondering, why a file with LF endings ends up having CRLF endings? The only reason I can think of is that it's transferred over FTP in ASCII mode. This can happen either manually (e.g. restoring a backup where you transfer the files over FTP in AUTO mode, not FTP in Binary mode or SFTP which is always a binary transfer) or you have Joomla's FTP mode enabled. In both cases the files could end up having their line endings converted to CRLF.

If, however, only parts of the file have a CRLF ending the problem would be user input in the NginX Conf Maker page. If I recall correctly submitting text in a textarea from a browser running under Windows generates CRLF line endings. Therefore as soon as you save anything in the NginX Conf Maker page from a Windows computer you'd end up with some bits having CRLF endings.

I want your help to understand which of these two scenarios (FTP or using a Windows computer to save the settings) is most likely to have happened so I can figure out how to reproduce it and see if I can do something about it :)

While typing this I thought that there might be an easy way to work around it. Can you please the latest dev release a try?

OK, then it's exactly what I thought: Windows browsers send CRLF when submitting multiline textarea fields. This is something I had seen before, once, only when I was doing some development. I thought that maybe I was doing something funky but, hey, at least it's not just me and now it's fixed!