Support

Admin Tools

#11517 Combine Javascript files

Posted in ‘Admin Tools for Joomla! 4 & 5’
This is a public ticket

Everybody will be able to see its contents. Do not include usernames, passwords or any other sensitive information.

Environment Information

Joomla! version
n/a
PHP version
n/a
Admin Tools version
n/a

Latest post by nicholas on Monday, 12 March 2012 14:18 CDT

elau24
Mandatory information about my setup:

Have I read the related troubleshooter articles above before posting (which pages?)? No
Have I searched the tickets before posting? Yes
Have I read the documentation before posting (which pages?)? Yes
Joomla! version: 5.2.5
PHP version: 5.3.10
MySQL version: 5.1.56-log
Host:
Admin Tools version: 2.2.0

Description of my issue:

For Combine JavaScript files, if I have one skipped file, it works fine. If I add another, it just skips the second file.

The culprit seems to be the return and line feed chars in the first line. It works properly if I strip r and n from $skip before doing fnmatch in core.php - function jscombine. Could you fix core.php accordingly? Thanks.

Also, links to the skipped files show up twice on view source, once right after the combined file and once at the regular spot if combine were turned off.

Thanks for checking this out.

nicholas
Akeeba Staff
Manager
Thank you for this bug report! I have found the cause of both problems and fixed them in the latest dev release. Please download and install on top of your existing release. Can you confirm that it fixes the problems you were experiencing?

Nicholas K. Dionysopoulos

Lead Developer and Director

πŸ‡¬πŸ‡·Greek: native πŸ‡¬πŸ‡§English: excellent πŸ‡«πŸ‡·French: basic β€’ πŸ• My time zone is Europe / Athens
Please keep in mind my timezone and cultural differences when reading my replies. Thank you!

elau24
Yup, it works perfect! Thanks :)

nicholas
Akeeba Staff
Manager
Great! Thank you for your feedback!

Nicholas K. Dionysopoulos

Lead Developer and Director

πŸ‡¬πŸ‡·Greek: native πŸ‡¬πŸ‡§English: excellent πŸ‡«πŸ‡·French: basic β€’ πŸ• My time zone is Europe / Athens
Please keep in mind my timezone and cultural differences when reading my replies. Thank you!

Support Information

Working hours: We are open Monday to Friday, 9am to 7pm Cyprus timezone (EET / EEST). Support is provided by the same developers writing the software, all of which live in Europe. You can still file tickets outside of our working hours, but we cannot respond to them until we're back at the office.

Support policy: We would like to kindly inform you that when using our support you have already agreed to the Support Policy which is part of our Terms of Service. Thank you for your understanding and for helping us help you!